nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

arm/stm32f401rc-rs485: Add support to WS2812 addressable LED

Open rcsim opened this issue 1 year ago • 3 comments

Summary

This commit adds support to WS2812 on stm32f401rc-rs485 boards.

Impact

This change impacts only stm32f401rc-rs485 board, adding the possibility of using an addressable LED compatible with WS2812. It also updates the documentation for stm32f401rc-rs485 accordingly.

Testing

Steps used for testing:

  1. Configure stm32f401rc-rs485: ws2812.
  2. Build and flash the board
  3. Access NSH and run ws2812 example application.

It was tested using Ubuntu 22.04.5 LTS on an x86 machine.

rcsim avatar Oct 12 '24 14:10 rcsim

[Experimental Bot, please feedback here]

The PR summary is missing some key information:

  • What functional part of the code is being changed? (e.g., specific driver, board configuration, etc.)
  • How does the change exactly work? (Briefly describe the technical implementation. Did you add a new driver? Modify an existing one?)

Impact:

  • The impact section is well-detailed.

Testing:

  • Insufficient information:
    • You need to provide the actual testing logs before and after the change. "your testing logs here" is not helpful.
    • Be specific about the compiler version used.
    • "ws2812 example application" - Provide the full path to this application within the NuttX apps repository.

To summarize: The PR needs more detail in the summary and testing sections to meet the NuttX requirements fully.

nuttxpr avatar Oct 12 '24 14:10 nuttxpr

@rcsim please rebase your branch and git push forced to fix the CI issue

acassis avatar Oct 21 '24 15:10 acassis

@xiaoxiang781216 @lupyuen what are these errors:

Cmake in present: nucleo-f722ze/cansock,CONFIG_ARM_TOOLCHAIN_CLANG
Configuration/Tool: nucleo-f722ze/cansock,CONFIG_ARM_TOOLCHAIN_CLANG
2024-10-21 23:03:46
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Select HOST_LINUX=y
CMake Error at cmake/nuttx_add_library.cmake:136 (add_library):
  Cannot find source file:

    /github/workspace/sources/nuttx/boards/arm/stm32f7/common/src/stm32_cansock.c
Call Stack (most recent call first):
  boards/CMakeLists.txt:34 (nuttx_add_kernel_library)


CMake Generate step failed.  Build files cannot be regenerated correctly.
-- Configuring done (0.3s)
CMake Error at cmake/nuttx_add_library.cmake:136 (add_library):
  Cannot find source file:

    /github/workspace/sources/nuttx/boards/arm/stm32f7/common/src/stm32_cansock.c
Call Stack (most recent call first):
  boards/CMakeLists.txt:34 (nuttx_add_kernel_library)


-- Generating done (0.2s)
CMake Generate step failed.  Build files cannot be regenerated correctly.
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_CLANG
  Building NuttX...
ninja: error: loading 'build.ninja': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory
cp: cannot stat 'nuttx.bin': No such file or directory
cp: cannot stat 'nuttx.bin': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory

acassis avatar Oct 22 '24 13:10 acassis

@xuxin930 could you look at why cmake output the above warning.

xiaoxiang781216 avatar Oct 23 '24 07:10 xiaoxiang781216

@rcsim please rebase to the latest master, stm32f7 CI break should be fixed

raiden00pl avatar Oct 23 '24 07:10 raiden00pl