nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

tools/btdecode.sh: add optional elf file parameter

Open XuNeo opened this issue 1 year ago • 1 comments

Summary

Allow to provide the path to elffile instead of hardcoding 'nuttx'. E.g.

./nuttx/tools/btdecode.sh aarch64-none-elf-addr2line crash.log build/nuttx

Impact

No

Testing

Tested with crash log generated from arm64.

./nuttx/tools/btdecode.sh aarch64-none-elf-addr2line crash.log build/nuttx
Backtrace for task 5:
0x00000000402a1318: cmd_mw at nsh_dbgcmds.c:259
0x000000004029d47c: nsh_command at nsh_command.c:1259
0x000000004029c964: nsh_execute at nsh_parse.c:874
 (inlined by) nsh_parse_command at nsh_parse.c:2840
0x000000004029ca50: nsh_parse at nsh_parse.c:2996
0x000000004029b018: nsh_session at nsh_session.c:246
0x000000004029aabc: nsh_consolemain at nsh_consolemain.c:79
0x00000000402945ac: nsh_main at nsh_main.c:80
0x0000000040298104: nxtask_startup at task_startup.c:70 (discriminator 1)
0x0000000040292cb8: nxtask_start at task_start.c:75

Backtrace for task 4:
0x000000004028f524: nxsem_wait at sem_wait.c:213
0x000000004028f54c: nxsem_wait_uninterruptible at sem_wait.c:254 (discriminator 1)
0x0000000040290960: work_thread at kwork_thread.c:214
0x0000000040292ca4: nxtask_start at task_start.c:124

Backtrace for task 3:
0x0000000040294b9c: up_idle at arm64_idle.c:63
0x000000004028136c: arm64_boot_secondary_c_routine at arm64_cpustart.c:240

Backtrace for task 2:
0x0000000040294b9c: up_idle at arm64_idle.c:63
0x000000004028136c: arm64_boot_secondary_c_routine at arm64_cpustart.c:240

Backtrace for task 1:
0x0000000040294b9c: up_idle at arm64_idle.c:63
0x000000004028136c: arm64_boot_secondary_c_routine at arm64_cpustart.c:240

Backtrace for task 0:
0x0000000040294b9c: up_idle at arm64_idle.c:63
0x00000000402812a0: arm64_boot_primary_c_routine at arm64_boot.c:207

XuNeo avatar Sep 29 '24 09:09 XuNeo

[Experimental Bot, please feedback here]

The PR does not meet the NuttX requirements fully. Here's why:

  • Summary: The summary is concise and explains the change well.
  • Impact: While all "No" answers are provided, a brief explanation for each "No" would be beneficial for reviewers to understand the rationale. For instance, "Impact on the user: No, the change only affects an internal tool and does not impact user functionality."
  • Testing:
    • The testing section lacks information about the build host and target used for verification.
    • Providing "Testing logs before change" is also crucial for comparison and understanding the actual improvement the change brings.

Recommendations:

  1. Expand on the Impact section: Briefly explain why each impact category is marked "No".
  2. Provide comprehensive testing information:
    • Specify the build host OS, CPU, compiler, etc.
    • Specify the target architecture, board configuration, etc.
    • Include testing logs before the change for comparison.

By addressing these points, the PR will be more informative and better aligned with NuttX's requirements.

nuttxpr avatar Sep 29 '24 09:09 nuttxpr