nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

nuttx/arch: Remove GCCVER and add compilation options directly.

Open cuiziwei1 opened this issue 1 year ago • 1 comments

Summary

Remove the judgment of GCCVER and add compilation options directly. If there is a problem that the compiler cannot recognize the compilation options, add it separately.

Impact

Testing

cuiziwei1 avatar Sep 29 '24 06:09 cuiziwei1

[Experimental Bot, please feedback here]

This PR appears to be missing critical information.

Here's a breakdown based on the provided template:

Summary:

  • What change is necessary: While it mentions removing "GCCVER judgment" and adding compilation options, it lacks specifics. What exact judgment is being removed? What specific compilation options are being added and for what purpose?
  • What functional part of the code is being changed: This is entirely missing. Which files, modules, or functionalities are affected by this change?
  • How does the change exactly work: Again, lacks specifics. How will the code function differently after this change?
  • Related Issues: Not provided. Are there any related issues in the NuttX or NuttX Apps repositories?

Impact:

  • All sections are empty. This section is crucial to understand the consequences of the PR. Provide details on how the change affects users, the build process, hardware, documentation, security, compatibility, and any other relevant factors.

Testing:

  • Incomplete: While it mentions testing, it doesn't provide actual details.
    • Build Host(s): List the operating systems, CPUs, and compilers used for testing.
    • Target(s): Specify the architectures, boards, and configurations used for testing.
    • Testing logs: Include actual logs from before and after the change to demonstrate the impact and correctness of the modification.

To improve this PR:

  1. Provide specific details in the Summary section about the changes made, their purpose, and the code sections involved.
  2. Thoroughly complete the Impact section, addressing each point with concrete information and explanations.
  3. Include comprehensive testing details: List all build hosts and targets, and provide actual testing logs demonstrating the change's effects.

By addressing these points, the PR will be much clearer, allowing reviewers to understand the changes and their implications effectively.

nuttxpr avatar Sep 29 '24 06:09 nuttxpr

@cuiziwei1 remove the merge patch from pr

xiaoxiang781216 avatar Sep 30 '24 02:09 xiaoxiang781216

@cuiziwei1 Please check the comments here: https://github.com/apache/nuttx/issues/13776

Older versions of GCC seem to be failing, we might need a workaround.

lupyuen avatar Oct 02 '24 00:10 lupyuen