nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

can: Add more critical section to fix the race condition

Open OceanfromXiaomi opened this issue 1 year ago • 1 comments

Summary

since routines called by IRQ need to be protected in SMP too.

Impact

Testing

OceanfromXiaomi avatar Sep 29 '24 06:09 OceanfromXiaomi

[Experimental Bot, please feedback here]

This pull request appears incomplete and lacks the necessary information to determine if it meets NuttX requirements.

Here's what's missing:

  • Summary:
    • Why is this change necessary? Is it a bug fix, performance improvement, new feature? Be specific.
    • What functional part of the code is being changed? Provide the specific module, file, or function names.
    • How does the change exactly work? Explain the technical details of your implementation.
    • Link any related issues.
  • Impact:
    • You have not filled out any of the impact sections. For each section (user impact, build impact, etc.), state "NO" or provide a detailed explanation if there is an impact.
  • Testing:
    • You need to provide actual testing details:
      • What build host(s) did you test on (OS, CPU, compiler)?
      • What target(s) did you test on (architecture, board, configuration)?
      • Include relevant "before" and "after" testing logs to demonstrate the change's effect.

Recommendations:

  1. Complete the missing information in the PR description. Provide clear and detailed answers to all the questions in each section.
  2. Ensure your code changes are well-documented. Add comments to explain the reasoning behind your changes and how they work.
  3. Follow the NuttX coding style guidelines.
  4. Thoroughly test your changes. Include test cases that cover both positive and negative scenarios.

A well-documented and tested PR is much more likely to be reviewed and merged quickly.

nuttxpr avatar Sep 29 '24 06:09 nuttxpr