nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

drivers/mmcsd: Rename mmcsd_read_csd to mmcsd_read_extcsd

Open gneworld opened this issue 1 year ago • 1 comments

Summary

Rename mmcsd_read_csd to mmcsd_read_extcsd, since it really read extcsd register not csd register and remove the temp buffer inside it.

Impact

mmcsd

Testing

cortex m55

gneworld avatar Sep 29 '24 02:09 gneworld

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements.

Missing Information:

  • Summary:
    • Why is this change necessary? What is the problem with the current naming and buffer usage?
    • How does removing the temporary buffer work? What are the implications for memory usage and performance?
  • Impact:
    • Be specific about which architectures, boards, or drivers are affected.
    • Impact on user: Will any user-facing APIs change?
    • Impact on compatibility: Are there any backward compatibility concerns?
  • Testing:
    • Provide more details about your build host and target environments:
      • OS versions
      • Compiler versions
      • Specific ARM board model
    • Testing logs: The provided logs are placeholders. Please include actual logs showing the behavior before and after the change.

Recommendations:

  • Expand the "Summary" section to clearly articulate the problem, solution, and rationale behind the changes.
  • Provide specific details in the "Impact" section, addressing all points with concrete information.
  • Replace placeholder testing logs with real output from your testing environment.

nuttxpr avatar Sep 29 '24 02:09 nuttxpr

let's ignore the ci error which is fixed by https://github.com/apache/nuttx/pull/13717 to avoid wasting the ci resource:

100  496k  100  496k    0     0  2326k      0 --:--:-- --:--:-- --:--:-- 2326k
common/xtensa_cpupause.c: In function 'xtensa_pause_handler':
Error: common/xtensa_cpupause.c:240:3: error: implicit declaration of function 'xtensa_savestate'; did you mean 'xtensa_setps'? [-Werror=implicit-function-declaration]
  240 |   xtensa_savestate(tcb->xcp.regs);
      |   ^~~~~~~~~~~~~~~~
      |   xtensa_setps
Error: common/xtensa_cpupause.c:243:3: error: implicit declaration of function 'xtensa_restorestate'; did you mean 'xtensa_context_restore'? [-Werror=implicit-function-declaration]
  243 |   xtensa_restorestate(tcb->xcp.regs);
      |   ^~~~~~~~~~~~~~~~~~~
      |   xtensa_context_restore
cc1: all warnings being treated as errors

xiaoxiang781216 avatar Sep 30 '24 13:09 xiaoxiang781216