nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

syslog/ramlog: add support of ramlog flush worker

Open anchao opened this issue 1 year ago • 1 comments

Summary

syslog/ramlog: add support of ramlog flush worker

  1. add RAMLOG_FLUSH options to support flush ramlog buffer to ARCH_LOWPUTC device
  2. add RAMLOG_FLUSH_WORKER to support background ramlog flush from workqueue in timeout RAMLOG_FLUSH_WORKER_TIMEOUT_MS

Signed-off-by: chao an [email protected]

Impact

N/A

Testing

ci-check

anchao avatar Sep 25 '24 05:09 anchao

[Experimental Bot, please feedback here]

The PR does not fully meet the NuttX requirements, specifically in the following areas:

Summary:

  • Insufficient detail: The summary provides a high-level overview but lacks specific details about the changes made. It should explain the rationale behind adding the RAMLOG_FLUSH option and the RAMLOG_FLUSH_WORKER functionality.
  • Missing references: It should include references to any related NuttX Issues or Pull Requests, if applicable.

Impact:

  • Not Applicable (N/A) is not acceptable: The impact section needs to be filled out thoughtfully, addressing each point. While the change might not impact some areas, it's important to explicitly state that and provide justification. For instance, the change likely impacts the build process and potentially hardware (if it relies on specific architecture features).

Testing:

  • Insufficient details:
    • "ci-check" isn't descriptive enough. Specify the CI environment used (OS, compiler, architectures).
    • Provide snippets of the actual testing logs showing the relevant changes in behavior. Simply stating "ci-check" doesn't offer proof of functionality.

Recommendations for Improvement:

  1. Expand the Summary: Clearly articulate the problem the PR solves and the technical approach used.
  2. Complete the Impact Section: Thoroughly analyze and describe the impact on each aspect (build, hardware, documentation, security, compatibility), providing details and justification.
  3. Provide Detailed Testing Information: List all build hosts and target environments used for testing. Include relevant snippets from the testing logs, highlighting the differences in behavior before and after the changes.

By addressing these points, the PR will better adhere to the NuttX requirements and provide reviewers with the necessary context for a comprehensive evaluation.

nuttxpr avatar Sep 25 '24 05:09 nuttxpr

@anchao what to do with this PR? Did you address Xiang Xiao comments?

acassis avatar Feb 12 '25 18:02 acassis

@anchao what to do with this PR? Did you address Xiang Xiao comments?

please hold this PR, I will enhance this capability in future.

anchao avatar Feb 13 '25 02:02 anchao