nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

rndis: correct usb descriptor

Open yangsong8-ai opened this issue 1 year ago • 1 comments

Summary

Fix the regression from https://github.com/apache/nuttx/pull/13190

Impact

Testing

yangsong8-ai avatar Aug 30 '24 09:08 yangsong8-ai

@masayuki2009 please try whether this patch can fix your problem.

xiaoxiang781216 avatar Aug 30 '24 13:08 xiaoxiang781216

@yangsong8-ai

Hmm, I tried your branch but it still does not work.

NuttShell (NSH)
nsh> uname -a
NuttX  0.0.0 83d7255f44 Aug 31 2024 08:55:49 arm spresense
nsh> ps
  PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK           STACK   USED  FILLED COMMAND
    0     0   0 FIFO     Kthread   - Ready              0000000000000000 001008 000512  50.7%  Idle_Task
    1     0 224 RR       Kthread   - Waiting  Semaphore 0000000000000000 001984 000312  15.7%  hpwork 0x2d05ce88 0x2d05ceac
    2     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 001984 000312  15.7%  lpwork 0x2d05ce50 0x2d05ce74
    3     3 100 RR       Task      - Running            0000000000000000 003032 001240  40.8%  spresense_main
    4     4 200 RR       Task      - Waiting  MQ empty  0000000000000000 000984 000464  47.1%  cxd56_pm_task
    6     6 100 RR       Task      - Waiting  Semaphore 0000000000000000 002016 000632  31.3%  telnetd
nsh> free
                 total       used       free    maxused    maxfree  nused  nfree
      Umem:    1131436      42596    1088840      43928    1087880    105      2
nsh> ifconfig
lo	Link encap:Local Loopback at RUNNING mtu 1518
	inet addr:127.0.0.1 DRaddr:127.0.0.1 Mask:255.0.0.0

eth0	Link encap:Ethernet HWaddr 00:e0:de:ad:be:ff at UP mtu 1500
	inet addr:10.0.0.2 DRaddr:10.0.0.1 Mask:255.255.255.0

             IPv4   TCP   UDP  ICMP
Received     0000  0000  0000  0000
Dropped      0000  0000  0000  0000
  IPv4        VHL: 0000   Frg: 0000
  Checksum   0000  0000  0000  ----
  TCP         ACK: 0000   SYN: 0000
              RST: 0000  0000
  Type       0000  ----  ----  0000
Sent         0000  0000  0000  0000
  Rexmit     ----  0000  ----  ----
nsh> ifconfig eth0 10.0.1.20
nsh> ifconfig
lo	Link encap:Local Loopback at RUNNING mtu 1518
	inet addr:127.0.0.1 DRaddr:127.0.0.1 Mask:255.0.0.0

eth0	Link encap:Ethernet HWaddr 00:e0:de:ad:be:ff at UP mtu 1500
	inet addr:10.0.1.20 DRaddr:10.0.1.1 Mask:255.255.255.0

             IPv4   TCP   UDP  ICMP
Received     0000  0000  0000  0000
Dropped      0000  0000  0000  0000
  IPv4        VHL: 0000   Frg: 0000
  Checksum   0000  0000  0000  ----
  TCP         ACK: 0000   SYN: 0000
              RST: 0000  0000
  Type       0000  ----  ----  0000
Sent         0000  0000  0000  0000
  Rexmit     ----  0000  ----  ----
nsh> ping -c 10 10.0.1.15
PING 10.0.1.15 56 bytes of data
ERROR: sendto failed at seqno 0: 101
ERROR: sendto failed at seqno 1: 101

masayuki2009 avatar Aug 30 '24 23:08 masayuki2009

I just converted to Draft to avoid been merged before we get it working

acassis avatar Aug 31 '24 15:08 acassis

@yangsong8-ai Thanks for the update. It works now. However, please change the commit log as follows

drivers: usbdev: Fix USB descriptor

This commit fixes the regression from https://github.com/apache/nuttx/pull/13190

masayuki2009 avatar Sep 03 '24 09:09 masayuki2009

OK, the commit log has been updataed. Thank you.

yangsong8-ai avatar Sep 03 '24 09:09 yangsong8-ai