nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

boards/sim: Defconfigs for nand and mnemofs

Open resyfer opened this issue 1 year ago • 4 comments

Summary

Adds nand and mnemofs sim configs.

Impact

Testers and users have default configuration files to use nand device simulators out of the box.

Testing

Manual testing using make after applying defconfigs.

resyfer avatar Aug 28 '24 19:08 resyfer

@resyfer please fix the compilation error:

Configuration/Tool: sim/nand
2024-08-28 20:23:32
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
Error: mtd/mtd_nand.c:82:16: error: 'nand_devscan' declared 'static' but never defined [-Werror=unused-function]
   82 | static int     nand_devscan(FAR struct nand_dev_s *nand);
      |                ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:102: mtd_nand.o] Error 1
mtd/mtd_nandram.c: In function 'nand_ram_storage_status':
Error: mtd/mtd_nandram.c:184:13: error: variable 'bad' set but not used [-Werror=unused-but-set-variable]
  184 |   uint8_t   bad;
      |             ^~~
Error: mtd/mtd_nandram.c:183:13: error: variable 'erases' set but not used [-Werror=unused-but-set-variable]
  183 |   uint16_t  erases;
      |             ^~~~~~
Error: mtd/mtd_nandram.c:182:13: error: variable 'writes' set but not used [-Werror=unused-but-set-variable]
  182 |   uint16_t  writes;
      |             ^~~~~~
Error: mtd/mtd_nandram.c:181:13: error: variable 'reads' set but not used [-Werror=unused-but-set-variable]
  181 |   uint16_t  reads;
      |             ^~~~~
mtd/mtd_nandram.c: At top level:
Error: mtd/mtd_nandram.c:178:13: error: 'nand_ram_storage_status' defined but not used [-Werror=unused-function]
  178 | static void nand_ram_storage_status(void)
      |             ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

acassis avatar Aug 29 '24 14:08 acassis

@resyfer please rebase to the last master which fix the ci issue.

xiaoxiang781216 avatar Aug 30 '24 13:08 xiaoxiang781216

@resyfer please rebase to the last master which fix the ci issue.

@xiaoxiang781216 Alright thanks a lot. Pushed after rebase.

resyfer avatar Aug 30 '24 13:08 resyfer

@xiaoxiang781216 Alright thanks for the suggestion! I've updated the same.

resyfer avatar Aug 30 '24 15:08 resyfer

@xiaoxiang781216 I think the CI was failing because %llx on MacOS, I think now it will break all new PRs

acassis avatar Sep 05 '24 17:09 acassis

@xiaoxiang781216 I think the CI was failing because %llx on MacOS, I think now it will break all new PRs

Nevermid, Saurav said the issue was fixed

acassis avatar Sep 05 '24 17:09 acassis