nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard
verified publisher icon apache

libc/memmem:porting open source memmem to Nuttx.

Open yangguangcai01 opened this issue 1 year ago • 5 comments

Summary

porting open source memmem to Nuttx.

Impact

memmem();

Testing

ci

yangguangcai01 avatar Aug 26 '24 13:08 yangguangcai01

@yangguangcai01 let's add lib_memem.c to https://github.com/apache/nuttx/blob/master/LICENSE#L6335 since it come from https://github.com/taleinat/byteshift_strstr.

xiaoxiang781216 avatar Aug 26 '24 16:08 xiaoxiang781216

@yangguangcai01 let's add lib_memem.c to https://github.com/apache/nuttx/blob/master/LICENSE#L6335 since it come from https://github.com/taleinat/byteshift_strstr.

done

yangguangcai01 avatar Aug 27 '24 07:08 yangguangcai01

@yangguangcai01 let's add lib_memem.c to https://github.com/apache/nuttx/blob/master/LICENSE#L6335 since it come from https://github.com/taleinat/byteshift_strstr.

in that case, i feel it's inappropriate to use our apache license in lib_memmem.c.

yamt avatar Aug 27 '24 07:08 yamt

@yangguangcai01 let's add lib_memem.c to https://github.com/apache/nuttx/blob/master/LICENSE#L6335 since it come from https://github.com/taleinat/byteshift_strstr.

in that case, i feel it's inappropriate to use our apache license in lib_memmem.c.

Has been replaced by MIT license.

yangguangcai01 avatar Aug 28 '24 11:08 yangguangcai01

Has been replaced by MIT license.

Then building of this component must be guarded by CONFIG_ALLOW_MIT_COMPONENTS option

raiden00pl avatar Aug 28 '24 13:08 raiden00pl

CONFIG_ALLOW_MIT_COMPONENTS is added, let's merge this patch.

xiaoxiang781216 avatar Oct 16 '24 10:10 xiaoxiang781216