nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

Upgrade Segger SystemView to V3.54

Open XuNeo opened this issue 1 year ago • 3 comments

Summary

Upgrade to the latest version V3.54.

Segger official github repo is out-of-date. Downloading from segger website is available but not stable. Thus I mirrored them to https://github.com/XuNeo/SystemView

Impact

Should have no impact on existing projects.

Testing

Tested on internal project, and stm32f429i-disco with newly added defconfig.

XuNeo avatar Jul 02 '24 13:07 XuNeo

why not get the source code from segger? https://www.segger.com/downloads/systemview/SystemView_Src_V354.zip

anchao avatar Jul 02 '24 15:07 anchao

CMake should also needs to be updated appropriately https://github.com/apache/nuttx/blob/master/drivers/segger/CMakeLists.txt

anchao avatar Jul 02 '24 15:07 anchao

@XuNeo also I think it is not a good idea to download these files from your personal repository. I know did it in good intention, but please don't do it. It is better to use the repository from official company.

acassis avatar Jul 02 '24 16:07 acassis

why not get the source code from segger?

As mentioned above, I originally tested locally and found out official website is not stable. It may be related to many download request in short time. But I tried today, and it seems works after many rebuild. Download URL is now updated.

CMake should also needs to be updated appropriately

Done.

XuNeo avatar Jul 03 '24 04:07 XuNeo

Error: segger/SystemView/SEGGER/SEGGER_SYSVIEW.c:2509:34: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 2509 | ENCODE_U32(pPayload, SHRINK_ID((U32)pHeap));

sim:segger reports warning about pointer to integer with different size. Segger may not work with 64bit. Warning is now suppressed.

XuNeo avatar Jul 03 '24 05:07 XuNeo

why not get the source code from segger?

As mentioned above, I originally tested locally and found out official website is not stable. It may be related to many download request in short time. But I tried today, and it seems works after many rebuild. Download URL is now updated.

CMake should also needs to be updated appropriately

Done.

@XuNeo you can use our mirror repository to save a backup: https://github.com/NuttX/apps-mirror-pkgs

acassis avatar Jul 03 '24 11:07 acassis

@XuNeo you can use our mirror repository to save a backup: https://github.com/NuttX/apps-mirror-pkgs

@acassis There's no use case in that mirror repository right now. Would you like to setup an example?

XuNeo avatar Jul 03 '24 13:07 XuNeo

@XuNeo you can use our mirror repository to save a backup: https://github.com/NuttX/apps-mirror-pkgs

@acassis There's no use case in that mirror repository right now. Would you like to setup an example?

Right, I will create an example for some app that you can yes as reference

acassis avatar Jul 03 '24 14:07 acassis