nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

cmake build seems lacking sethost.sh equivalent

Open yamt opened this issue 2 years ago • 6 comments

yamt avatar Jan 04 '24 06:01 yamt

I think this should have been designed in the nuttx_kconfig module. https://github.com/apache/nuttx/blob/3bac4492865ad3bd4c293e9d751163e090634678/cmake/nuttx_kconfig.cmake#L68 current settings are not perfect enough.

xuxin930 avatar Jan 05 '24 09:01 xuxin930

I think this should have been designed in the nuttx_kconfig module.

https://github.com/apache/nuttx/blob/3bac4492865ad3bd4c293e9d751163e090634678/cmake/nuttx_kconfig.cmake#L68

current settings are not perfect enough.

thank you. i was not aware of the cmake fragment.

however, i think we need something actually involving kconfig-tweak because some other configs depend on these CONFIG_HOST_xxx. eg. https://github.com/apache/nuttx/blob/3bac4492865ad3bd4c293e9d751163e090634678/arch/sim/Kconfig#L210

yamt avatar Jan 05 '24 09:01 yamt

kconfiglib provides a method named setconfig, which similar to kconfig-tweak, I think we can add the cmake target or command of setconfig wrapper to support the sethost feature: https://github.com/ulfalizer/Kconfiglib/blob/master/setconfig.py

anchao avatar Jan 11 '24 04:01 anchao

I wrote a cmake sethost, but it's a little hacky.

Now that I see this discussion, I decided to follow this discussion and try to modify my code.

  • #11608

W-Mai avatar Jan 27 '24 08:01 W-Mai

I wrote a cmake sethost, but it's a little hacky.

Now that I see this discussion, I decided to follow this discussion and try to modify my code.

  • #11608

It's best to align with @xuxin930,maybe he's working on the relevant implementation

anchao avatar Jan 27 '24 11:01 anchao

It's best to align with @xuxin930,maybe he's working on the relevant implementation

Great!

W-Mai avatar Jan 27 '24 11:01 W-Mai