nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

Toolchain command do not take effect in CMake build after menuconfig settings

Open xuxin930 opened this issue 1 year ago • 2 comments

Here is an example:

Our current Toolchain File overwrite the ARCHIVE command https://github.com/apache/nuttx/blob/992719730f355ed3132c3204153f919822870074/arch/arm/src/cmake/Toolchain.cmake#L92-L94 but <CMAKE_AR> makes different choices depending on whether LTO is enabled or not. https://github.com/apache/nuttx/blob/992719730f355ed3132c3204153f919822870074/arch/arm/src/cmake/Toolchain.cmake#L75-L86 If every Toolchain configs is configured in defconfig, everything will work normally. But if LTO is not enabled in defconfig and I call cmake --build -t menuconfig to open LTO, then the expectation is different from the setting.

Because the execution of CMake is divided into three stages: configure, generate and build. the Toolchain command (such as CMAKE_AR above) is configured in stages configure, generate and is solidified in the generated build file (such as Makefile). so in the end this menuconfig modification will NOT take effect.

How can we improve this to make it work properly?

xuxin930 avatar Dec 26 '23 07:12 xuxin930

@pkarashchenko any idea?

acassis avatar Dec 28 '23 15:12 acassis

In this case, we should regenerate Makefile?

xiaoxiang781216 avatar Dec 28 '23 18:12 xiaoxiang781216