nuttx
nuttx copied to clipboard
apache
CMake version.h compilation error
When using the CMake build system, there seems to be an issue with the generation of version.h. Specifically, I get the following error
nuttx/build/include/nuttx/version.h:7:1: error: missing terminating " character 7 | "
caused by the closing apostrophe being wrongly in the next line:
#define CONFIG_VERSION_STRING "12.3.0
"
After moving the apostrophe to the right line, it compiles. When using the Makefile build system, this issue doesn't occur.
My system is the following: System: Debian 11 6.1.0-0.deb11.13-amd64 Toolchain: arm-gnu-toolchain-13.2.rel1-x86_64-arm-none-eab Board: nucleo-h743zi2 Config: nsh
@maxikrie thank you for reporting, I think the error is here:
cmake/nuttx_mkversion.cmake:
file(APPEND ${VERSION_H} "#define CONFIG_VERSION_STRING \"${NUTTX_VERSION}\"\n")
Could you please replace it with:
file(APPEND ${VERSION_H} "#define CONFIG_VERSION_STRING \"${NUTTX_VERSION}\"\")
And test again.
@acassis Thanks for pointing me to the relevant file. Unfortunately, your proposed fix doesn't resolve the issue, but results in
#define CONFIG_VERSION_STRING "12.3.0
"#define CONFIG_VERSION_MAJOR 12
It seems like the command in line 26 outputs NUTTX_VERSION with an added "\n" character in the end, which causes the observed issue. I could resolve this by adding the following in line 33
string(REPLACE "\n" "" NUTTX_VERSION ${NUTTX_VERSION})
Maybe somebody can suggest a cleaner solution?
In any case, it is great to now have the option of the CMake build!
I did hit this while building NuttX from source, opened https://github.com/apache/nuttx/pull/13081 with the fix.
