nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard
verified publisher icon apache

video/vnc: add vnc_fb_register

Open jianglianfang opened this issue 2 years ago • 4 comments

Summary

Optimize the initialization of vnc, change it to vnc_fb_register.

Impact

Nuttx vnc

Testing

run nuttx with vnc

jianglianfang avatar Dec 13 '23 09:12 jianglianfang

I successfully compiled sim:vncserver in the docker [ https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux], Proceed as follows：

  1. sudo docker run -it -v $PWD:/home/nuttx ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest@sha256:324c3660ddcc78fd7efcee52b80bc8060f007da44a3f51b7551bb27ba16ab34a /bin/bash
  2. cd /home/nuttx/nuttx
  3. rm Make.defs
  4. ln -s /home/nuttx/nuttx/tools/../boards/sim/sim/sim/scripts/Make.defs Make.defs
  5. make distclean
  6. ./tools/configure.sh -l sim:vncserver
  7. make clean;make

jianglianfang avatar Dec 26 '23 12:12 jianglianfang

I guess the error is due to linker doesn't move the unused fb_register from final image. It could be fixed by changing fb_register to macro or inline function.

xiaoxiang781216 avatar Dec 27 '23 13:12 xiaoxiang781216

@jianglianfang before we merge it, could you please confirm that this tutorial still working after your modifications: https://nuttx.apache.org/docs/latest/platforms/sim/sim/index.html#running-vnc-server ?

acassis avatar Dec 28 '23 15:12 acassis

Could you please verify the compilation error?

acassis avatar Feb 02 '24 19:02 acassis