apache
boards/stm32h7/h747ai: Support for generic STM32H747AI MCU
Summary
Adds dual-core support for the STM32H747AI with a simple generic example board equipping six LEDs, I2C, and SPI channels.
Impact
Small impact on the existing code base for H7.
Testing
Tested against a standalone AI variant.
@royratcliffe could you rearrange your patch and fix the conflict?
Thanks @xiaoxiang781216. Will do.
@royratcliffe thank you very much for your PR and sorry for delay. I missed that commit!
Please fix this CI issue:
Warning: nuttx/arch/arm/src/imxrt/imxrt_mpuinit.c:128:6: warning: #include outside of 'Included Files' section
@royratcliffe could you rearrange your patch and fix the conflict?
Thanks @xiaoxiang781216. Will do.
@royratcliffe I think what Xiang was saying it to squash some these commits, there are some "fix typo" that could be squashed in a single command.
Please refer to our documentation explaining how to do that: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
Other suggestion: use rebase instead of merge to keep your branch in sync with upstream. Our documentation how explain how to create the upstream, how to keep in sync, etc. Any issue, please don't hesitate to ask, ok?
@royratcliffe Please fix these coding style issues:
Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/stm32h7/stm32_serial.c:1701:78: error: Long line found
Error: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/stm32h7/h747ai/src/stm32_bringup.c:302:78: error: Long line found
Error: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/stm32h7/h747ai/src/stm32_bringup.c:305:78: error: Long line found
Error: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/stm32h7/h747ai/src/stm32_bringup.c:321:1: error: Blank line precedes right brace at line
Error: Process completed with exit code 1.
You can use checkpatch.sh to find these issues before submitting the PR, there is more info in our website.
@royratcliffe thank you for the fix. Please take a look at our git repository and look for other boards inclusion pull requests, normally a board inclusion will have 2 or 3 commits only. Your PR has 53 commits. Please squash commits that logically do same thing.