nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

add make export to the ci to check if the archive is correctly exported

Open trns1997 opened this issue 2 years ago • 5 comments

Summary

  • Test make export archive in the CI
  • Add CONFIG_ARCH_BOARD_COMMON to all defconfig by default for all boards

Closes #10388

Impact

Testing

trns1997 avatar Sep 07 '23 15:09 trns1997

@acassis @xiaoxiang781216 is there a simple way to test the CI locally?

trns1997 avatar Sep 07 '23 17:09 trns1997

@acassis @xiaoxiang781216 is there a simple way to test the CI locally?

  1. launch the docker used by ci from here: https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux
  2. Download nuttx/apps git
  3. run the follow command:
cd nuttx/tools/ci
./cibuild.sh -c -A -R testlist/arm-01.dat

replace arm-01.dat with the test suite you want to run.

xiaoxiang781216 avatar Sep 07 '23 18:09 xiaoxiang781216

@acassis @xiaoxiang781216 is there a simple way to test the CI locally?

1. launch the docker used by ci from here:
   https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux

2. Download nuttx/apps git

3. run the follow command:
cd nuttx/tools/ci
./cibuild.sh -c -A -R testlist/arm-01.dat

replace arm-01.dat with the test suite you want to run.

I simply called the testbuild.sh in the tools directory to test if the build process works, which is more or less what you suggest but the fail variable always returns 1 is that normal for master?

trns1997 avatar Sep 08 '23 06:09 trns1997

@trns1997 are you planing to adding a new PR about this matter?

I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too.

acassis avatar Apr 24 '24 17:04 acassis

@trns1997 are you planing to adding a new PR about this matter?

I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too.

I am not sure, honestly i had forgotten about this PR. We could consider this approach https://github.com/apache/nuttx/issues/10388#issuecomment-1691893627 . Let me know what you think, if you want i can look into it and create a new PR.

trns1997 avatar Apr 24 '24 19:04 trns1997