nuttx-apps icon indicating copy to clipboard operation
nuttx-apps copied to clipboard

Published 20 hours ago • verified publisher icon apache

Trigger clean and distclean for all directory which contain Makefile

Open xiaoxiang781216 opened this issue 2 years ago • 4 comments

Summary

Found by https://github.com/apache/incubator-nuttx/pull/6586

Impact

make distclean and make clean

Testing

Pass CI

xiaoxiang781216 avatar Jul 09 '22 05:07 xiaoxiang781216

This was the old behavior, before filtering based on .depend and .kconfig. Do you want to bring it back? This will increase the execution time of multiple phases in build and configuration.

Ouss4 avatar Jul 10 '22 18:07 Ouss4

This was the old behavior, before filtering based on .depend and .kconfig. Do you want to bring it back? This will increase the execution time of multiple phases in build and configuration.

Here is my thought:

  1. Compare with the compile and link, the time to execute clean/distclean is very small
  2. We need ensure the result is right before applying the optimization

xiaoxiang781216 avatar Jul 10 '22 19:07 xiaoxiang781216

We need ensure the result is right before applying the optimization

Yes, sure, but I wanted to make sure that there is no other way except scanning all directories. When we had the nightly Jenkins build, that was building multiple configurations one after the other, this had a somewhat significant impact. We don't use Jenkins anymore, and if this way is not properly working in all build modes, then yes we need to revert it.

Ouss4 avatar Jul 11 '22 08:07 Ouss4

Compare with https://github.com/apache/incubator-nuttx-apps/pull/1214, the performance lose of this PR is huge

xiaoxiang781216 avatar Jul 11 '22 08:07 xiaoxiang781216