nutch icon indicating copy to clipboard operation
nutch copied to clipboard

Published 20 hours ago • verified publisher icon apache

NUTCH-2887 Migrate to JUnit 5 Jupiter

Open lewismc opened this issue 2 years ago • 1 comments

WIP to address https://issues.apache.org/jira/browse/NUTCH-2887

lewismc avatar Oct 24 '23 16:10 lewismc

OK, I'm over the bulk of the work here. A brief synopsis of what has been done so far...

  • new junit5 jupiter dependencies added to ivy.xml
  • All assertions migrated to new org.junit.jupiter.api.Assertions package
  • All annotations migrated to new org.junit.jupiter.api package e.g. @Test
  • @Before and @After no longer exist; migrated to @BeforeEach and @AfterEach
  • @Ignore no longer exists: migrated to @Disabled but we should definitely review these cases and see if we can activate them

I think we may be able to improve test execution by investigate parallel execution but that will come in a subsequent PR

Additionally, loads of tests are failing right now due to my limited understanding of how to migrate from Ant's legacy junit task to the junit5 junitlauncher task.

I think one more push and this PR should be ready for review.

lewismc avatar Oct 25 '23 05:10 lewismc