nifi
nifi copied to clipboard
NIFI-11520: Add a menu to display Flow Analysis report results
Summary
This PR introduces a menu to the canvas that displays the results of a Flow Analysis report. This will enable UI users to see a list of their established rules and violations (scoped to the currently selected Process Group in the canvas). I'm not sure how this will translate over to the new UI work that's currently in-progress, but I'll gladly take responsibility for adding it there as well.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
- [x] Apache NiFi Jira issue created
Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as
NIFI-00000
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such
NIFI-00000
Pull Request Formatting
- [x] Pull Request based on current revision of the
main
branch - [x] Pull Request refers to a feature branch with one commit containing changes
Verification
Please indicate the verification steps performed prior to pull request creation.
Build
- [x] Build completed using
mvn clean install -P contrib-check
- [x] JDK 21
Licensing
- [x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
- [x] New dependencies are documented in applicable
LICENSE
andNOTICE
files
Documentation
- [x] Documentation formatting appears as expected in rendered files
I'm not sure how this will translate over to the new UI work that's currently in-progress, but I'll gladly take responsibility for adding it there as well.
Hey @sardell 👋 Thanks for the PR! Would love to have you help contribute this into the new UI work. That work is still in progress and is being tracked here [1]. Please add a line item there and file a sub-task. Please see [2] for a high-level overview of layout, structure, and dataflow throughout the application. These details will be formalized in a README soon, but wanted to pass along a pointer in the meantime.
The UX in this new effort is largely unchanged from the previous UI. So any designs for this PR should be directly applicable to the new UI. The only real difference is moving away from the large full-screen modal (though that may still be used for component documentation or custom UIs yet to be developed) to separate pages.
[1] https://issues.apache.org/jira/browse/NIFI-12400 [2] https://github.com/apache/nifi/pull/8053
Hey @sardell 👋 Thanks for the PR! Would love to have you help contribute this into the new UI work. That work is still in progress and is being tracked here [1]. Please add a line item there and file a sub-task. Please see [2] for a high-level overview of layout, structure, and dataflow throughout the application. These details will be formalized in a README soon, but wanted to pass along a pointer in the meantime.
The UX in this new effort is largely unchanged from the previous UI. So any designs for this PR should be directly applicable to the new UI. The only real difference is moving away from the large full-screen modal (though that may still be used for component documentation or custom UIs yet to be developed) to separate pages.
[1] https://issues.apache.org/jira/browse/NIFI-12400 [2] #8053
@mcgilman Thanks for that quick rundown. I'm very excited to see this UI framework update coming together so fast! I've added a line item and sub-task to NIFI-12400 and will begin work shortly.
@tpalfy I believe I addressed all of the issues you pointed out. When you have time, could you please take another look?
LGTM Tested with built-in and some custom rules. All issues raised by me seem to be addressed.
@mcgilman I believe I addressed all your comments. Thanks for the quick assist, @tpalfy!
NOTE: This PR is now dependent on https://github.com/apache/nifi/pull/8475, which should be merged first.