nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-10192 Cache schema request result for reuse

Open kent-nguyen opened this issue 2 years ago • 1 comments

Summary

NIFI-10192

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [x] Pull Request based on current revision of the main branch
  • [x] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [x] Build completed using mvn clean install -P contrib-check
    • [x] JDK 8
    • [x] JDK 11
    • [x] JDK 17

Licensing

  • [x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [x] Documentation formatting appears as expected in rendered files

kent-nguyen avatar Jul 25 '22 05:07 kent-nguyen

Looks like you have some Checkstyle errors, please run your maven command with the -Pcontrib-check before pushing commits, thanks!

mattyb149 avatar Jul 25 '22 12:07 mattyb149

Looks like all of the automated checks have passed - was there anything else that needs to be done before this can be accepted @mattyb149 ?

chnorton avatar Aug 22 '22 00:08 chnorton

@markap14 did the work 5955, he would be the best to understand the issue and the side effects, ie. if this is the right fix or there needs to be an additional refactor which includes looking at the original fix again.

ottobackwards avatar Aug 26 '22 11:08 ottobackwards

Can this be closed if #6364 replaces it?

mattyb149 avatar Sep 06 '22 21:09 mattyb149

Can this be closed if #6364 replaces it?

Yes, this one can be closed, I have taken over the PR from @kent-nguyen and implemented a modified solution based on the given feedback.

Aerilym avatar Sep 07 '22 12:09 Aerilym

Closing based on comments, thanks @Aerilym!

exceptionfactory avatar Sep 29 '22 19:09 exceptionfactory