nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-9814: Add Range Sampling strategy to SampleRecord

Open mattyb149 opened this issue 2 years ago • 2 comments

Adds range/interval sampling to SampleRecord, to selectively choose which records / ranges are sampled.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [x] Has your PR been rebased against the latest commit within the target branch (typically main)?

  • [x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • [x] Have you written or updated unit tests to verify your changes?
  • [ ] Have you verified that the full build is successful on JDK 8?
  • [x] Have you verified that the full build is successful on JDK 11?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

mattyb149 avatar Mar 17 '22 19:03 mattyb149

Very nice addition. I tested with various permutations (i.e. including an open start range, an open end range, leaving the value as a blank string and it behaved as designed.

Clean, clear code.

LGTM +1

NissimShiman avatar Jun 20 '22 16:06 NissimShiman

Just noticed this was still open ...

Follow commit looks good. Nice catch with additional @WriteAttributes of mime.count Verified that it is indeed added on flowfile output and nice cleaning up of customValidate() based on new .dependsOn() for the various PropertyDescriptors

I apologize if this was waiting on comment following up on the latter commit LGTM +1

NissimShiman avatar Aug 03 '22 19:08 NissimShiman