nifi
nifi copied to clipboard
NIFI-9492: Fix for Chinese VPCE - Tests included
Description of PR
fixes bug NIFI-9492 The AWS Abstract Processor not handle Chinese VPCE. I made some changes to make it available to parse correctly Chinese VPCE
For all changes:
-
[X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? NIFI-9492
-
[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
-
[X] Has your PR been rebased against the latest commit within the target branch (typically
main
)? -
[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.
For code changes:
- [ ] Have you ensured that the full suite of tests is executed via
mvn -Pcontrib-check clean install
at the rootnifi
folder? - [X] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
Thanks for the contribution @jynolen . I wonder, though, if there are other VPCE endpoints that may need to be used, other than just .com
and .com.cn
? We probably should not just slowly add them one at a time. Instead, perhaps it makes sense to check if the URL ends with ".vpce.amazonaws.com" followed by .<anything>
and if so extract that whole suffix and pass that on. Thoughts?
Hello @markap14 I really don't think so. Even for GOV region. AWS China is a special case for reasons that are bigger than me 😜. TBH I agree with you, but my level of Java is not enough, I had it with maximum safety. We had a blocking usecase that wait this feature to be merge upstream, I hope someone can provide a more global way but we really need this.
Thks.
Any updates on this case ?
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
Not stale