nifi-minifi icon indicating copy to clipboard operation
nifi-minifi copied to clipboard

MINIFI-495 Provide an explicit dependency on minifi-assembly for the …

Open apiri opened this issue 5 years ago • 0 comments

…minifi-docker project which makes use of the artifact in generating images.

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [ ] Is your initial contribution a single, squashed commit?

For code changes:

  • [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
  • [ ] Have you written or updated unit tests to verify your changes?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
  • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

apiri avatar Oct 19 '19 02:10 apiri