netbeans
netbeans copied to clipboard
prevent attempt to create method that will fail for missing return type
closes #8594
Implementation: Add method to test that the return type given is useable by the CreateMethod fix.
Uses that method in 4 places in CreateElement.
Added test to verify that no fix is suggested by create element. Added test data file with minimal working example as given in #8594
With this fix in place, the hint to create a method is not shown; instead, the line with the combination of var type and unknown method call is flagged as an error.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
- [ ] Was this PR correctly labeled, did the right tests run? When did they run?
- [ ] Is this PR squashed?
- [ ] Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
- [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: don't merge. (full wiki article)