netbeans icon indicating copy to clipboard operation
netbeans copied to clipboard

Fix parsing of JDK 17+ Javadoc of methods without HTML a tags.

Open t-gergely opened this issue 1 year ago • 2 comments

NetBeans didn't show Javadoc descriptions for a lot of OpenJDK (21) methods. This simple patch works for me, but feel free to drop this PR, and fix the bug whatever way you like.

t-gergely avatar Oct 04 '24 23:10 t-gergely

Linking with #5127 Thanks for this. I think makes sense, but I can't remember the reason I marked state as a_open. Possibly also me not fully understanding the quirks of the state engine! :smile: Hopefully this change doesn't break anything elsewhere. Parsing with a HTML 3.2 parser is becoming more problematic!

It would be good to generate test files for Javadoc 21+ alongside the ones introduced in the other PR. The source files are there. If you felt like adding that to this, that would be a great addition and way to prove your change!

neilcsmith-net avatar Oct 18 '24 13:10 neilcsmith-net

Hi, thanks for the contribution, but we require a valid email address in the commit header

Yes, it was a bad idea to post this PR. Sorry. I probably should have attached a patch to an issue instead. You may commit the patch yourselves: I don't take credit for anything in it.

It would be good to generate test files for Javadoc 21+ alongside the ones introduced in the other PR

I don't see a good reason for that. OTOH methods testJavadoc8Class() and testJavadoc11Class() also don't test the default constructors. Which has the consequence of the missing (cloned) test case for the current bug. So I recommend adding those tests, too.

t-gergely avatar Oct 22 '24 09:10 t-gergely

@t-gergely could you please check the comment from @mbien?

matthiasblaesing avatar Nov 17 '24 19:11 matthiasblaesing

@t-gergely could you please check the comment from @mbien?

I think I've already replied to that.

t-gergely avatar Nov 17 '24 23:11 t-gergely