apache
Add global maven goal presets
- add
mvnwupdater and a few maveniverse toolbox diagnostic goals as global preset - add right click menu action which leads directly to the global rule editor for easy add/edit/remove, right next to the project specific rule editor
- some layout adjustments to both global and custom goal windows so that they resize nicely
- minor language level cleanup
"Edit Global Goals" (new) will open the (already existing) window:
(also accessible from maven execution options)
note: I reverted a few things to not change too much at once. What I originally planned was to combine the global and per-project goal editor windows and I wanted to move the global editor panel to a card in the main maven options. However, the problem is that the two windows and the tools->options windows have different ways how to handle persistence, so this would have been too much at once. Still something we can do at some point.
Looks good!
Ideally would have a link to Edit Project Goals that opens the right section of the project properties, between the Other Goals... and Edit Global Goals... links. Possibly another separator between Other Goals... and the edit actions to emphasize execution vs edit?
Thanks! Think that works and a good change for NB23.
We could perhaps (in future!) standardize some of the terminology here. We use Goals and Actions in different places, and neither entirely overlaps with Maven's concept of Goal.
we would probably have to call it "action" everywhere to be technically correct, since compile is a phase and compile:compile a goal which happens to be in that phase. The action presets work for both, phases and goals.
Its just that goal is the more familiar term most likely, so if it happens to support phases it is probably ok to call the menu entry point "Edit Goals..."?
I would probably leave it as is for now tbh but I would also have no problem to change it to "Edit Actions...".