apache
MacOS: Make SVG/HiDPI icons work in the main menu bar
Adjust the Icon implementation in ImageUtilities to make SVG/HiDPI icons work in the MacOS menu bar.
This requires Java 9 or above, due to the need to implement the MultiResolutionImage interface.
The effect can be seen e.g. for the Undo and Redo actions in the Edit menu, which have SVG icons present. Some more menu actions will have SVG icons once https://github.com/apache/netbeans/pull/7463 is merged.
(I'd upload a screenshot here but I don't have a Mac available at the moment. I have tested the patch on MacOS many times in the last 6 months, though, and it has also been confirmed not to cause trouble on the IDE on my Windows machine.)
I see a test failing called "NetBeans / APISupport Modules on Linux/JDK 8 (pull_request)". Is the openide.util.ui module (which contains ImageUtilities) required to work with Java 8? In that case this patch can't work.
@mbien Ah, sorry, I misunderstood that comment to be about something that happened in the other PR. Now done and pushed again... waiting for tests to pass.
@neilcsmith-net nope, I marked the two points I commented on as resolved - all good from my side.
@mbien you should be able to dismiss the review then if you don't want to switch to approve.
@eirikbakke over to you to merge.
done, I thought dismiss review would delete everything i said, but all it does is to remove the red marker. So I always pressed the re-request review button to get rid of the red marker.