PHP wrong format indentation

[riksoft]

Apache NetBeans version

Apache NetBeans 22

What happened

The code inside a function influences how is formatted the code into another function when making use of ALT+Shift+F I already filed this bug that is a similar problemi for JS (https://github.com/apache/netbeans/issues/7243) but this one I think it's even worse.

Language / Project Type / NetBeans Component

PHP project

How to reproduce

(1) Comment the line $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; and press ALT Shift+F You'll see "Array(" in the function stuff() moving in the right position. (2) Remove the comment from $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; and "array(" will move again in the bad position. (3) In the line $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; change "test3" with "test33333333333333333333" and you'll see "array(" moving further right. I haven't found any workaround to solve this problem.

<?php

class test
{
	public static function test($res)
	{
		$test4 = [1, 2, 3, 4];

		// The lenght of this line changes the format position of "array("
		// in function stuff() :-o !!!
		// E.g. try to change test3 into test333333
		// and format the code again: "array(" will be moved further right.
		// Or simply comment the following line and reformat
		$res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)];

		return $res;
	}


	public static function stuff()
	{
		return array_merge(self::registerRules(),
										 array(
			 'opt1' => FILTER_SANITIZE_NUMBER_INT,
			 'opt2' => FILTER_SANITIZE_NUMBER_INT
		  )
		);
	}
}

I'd like "array(" in the return of stuff() to stay on the first line, like this

return array_merge(self::registerRules(), array(
			 'opt1' => FILTER_SANITIZE_NUMBER_INT,
			 'opt2' => FILTER_SANITIZE_NUMBER_INT
		  )

or something like this

return array_merge(self::registerRules(),
				array(
					'opt1' => FILTER_SANITIZE_NUMBER_INT,
					'opt2' => FILTER_SANITIZE_NUMBER_INT
				)
		);

But that's not the point: regardless of what I expect to see, the problem is that "array(" moves right according to the length of $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; in the other function. That's quite weird.

PS: If this could help, I format all my code with tabs, not spaces.

Did this work correctly in an earlier version?

No / Don't know

Operating System

Debian Bookworm (12)

JDK

Java: 17.0.11; OpenJDK 64-Bit Server VM 17.0.11+9-Debian-1deb12u1 - Runtime: OpenJDK Runtime Environment 17.0.11+9-Debian-1deb12u1

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No

Attached

Screenshot of the editor formatting options

zip with export of formatting options format.zip

[riksoft]

I've noted that the problem is the use of implode() E.g the problem does not happen turning $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; into

$sTest4 = implode(',', $test4);
$res = ['test1' => 1, 'test2' => 2, 'test3' => $sTest4];

[junichi11]

I can't reproduce it. Please write your formatting options, an expected result, and actual result.

[riksoft]

I've modified the first post adding the info about formatting (screenshots + format setting export) + what I would expect.

[junichi11]

Could you attach an example project as a zip file?

1. Create a new project
2. Write an example code
3. Project properties > Formatting > Use project specific options
4. Set your formatting option to reproduce it
5. Zip your example project
6. Attach it to this issue

[riksoft]

Your idea about using Project properties > Formatting > Use project specific options (that I didn't even know it existed :-) ) was the key to start comparing the global with the specific settings (that was not affected by such problem). So comparing and trying I've found the problem is here:

Actually not even the default is good because it causes this problem

The best is Setting Never + "wrap after (" and "wrap )"

And this solves the problem. I'm gonna set it in the global option as well! Doesn't split unless I do and if I do it wraps well.

[junichi11]

Please attach your example project.

[riksoft]

For unknown reason I wasn't able to have back the exact bad behaviour mentioned before. It's almost the same though. The only difference is that before the problem was only on the line self::registerRules(), array( with the keyword array moving far right depending on the $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; lenght while in this example it's even worse because the line $res = ['test1' => 1, 'test2' => 2, 'test3' => implode(',', $test4)]; that in the original case was staying put, in this case $test4 goes on the next line.

junichi.tar.gz

[junichi11]

Reproducible. Thanks!

[riksoft]

Thanks to you, you're doing a great job!