Made HCL AST on records

Open lkishalmi opened this issue 1 year ago • 1 comments

Well,

I've been waiting for this. I think this is an improvement comparing to the previous version at least for reading. The implementation is more safe.

Performance vise it might be worse than before, though I have no tests to prove that.

Anyway, tests are passing.

Now I'm waiting for Java 21 and it's record patterns.

Feb 22 '24 20:02 lkishalmi

@matthiasblaesing could you share your opinions? I've always valued your wisdom. This Java 17 and records a bit new to me, so I'm eager to see other opinions as well.

Feb 29 '24 19:02 lkishalmi

this is causing graal tests to fail since they run on EOL JDK 11 graalvm, but I think i found a way to temp fix this without revert. Testing it locally atm.

Mar 18 '24 08:03 mbien