apache
Provide hints for conversion to Virtual thread executor when thread pools are used
Provide hints for converting thread pools(newFixedThreadPool, newCachedThreadPool) to virtual thread pool executor. When ThreadFactory is passed as argument to , then only a hint suggestion for converting the thread pool to newThreadPerTaskExecutor is provided. Code is not directly rewritten in this case.
VTs are great and I am all for using new features and having code transformations which help with migration but maybe not enabled by default
Emphasis mine, but yes, agree, IMO should not be enabled by default, for now at least.
Based on the comments we have now changed to give hints for the new feature of VT thats available. Instead of converting the code. So no more automatic conversion.Hope this clarifies.
@singh-akhilesh please make sure there's a milestone set when merging, thanks!