netbeans icon indicating copy to clipboard operation
netbeans copied to clipboard

Published 20 hours ago • verified publisher icon apache

Fix bitshfits in the OS constants after the removal of OS_WIN95 and OS_WIN98

Open lkishalmi opened this issue 1 year ago • 4 comments

This PR restores the bit assignment to the OS constants before #4025

lkishalmi avatar Aug 11 '22 16:08 lkishalmi

I was not able to add @BradWalker to the reviewers, so I mention him here.

lkishalmi avatar Aug 11 '22 16:08 lkishalmi

Opened #4498 as alternative option for discussion - either need to revert entirely or patch additional fixes in this PR.

@lkishalmi the typo in your title is fantastic - describes the situation perfectly :laughing:

neilcsmith-net avatar Aug 12 '22 08:08 neilcsmith-net

Okay, I much prefer to fix the bitshift in the field than revert the changes!

BradWalker avatar Aug 12 '22 12:08 BradWalker

@lkishalmi the typo in your title is fantastic - describes the situation perfectly laughing Sometimes I have very bad typo days. This PR was created on such a day. I think I typed bitshit at leasr 2 times before filing the PR unintentionally. Well shift happens...

lkishalmi avatar Aug 14 '22 23:08 lkishalmi

Closed in favour of full revert of #4025 in #4498

neilcsmith-net avatar Aug 15 '22 16:08 neilcsmith-net