Cleanup warnings related to raw type List

[BradWalker]

Cleanup warnings related to unchecked call to add as a member of raw type List..

Here is an example.

[repeat] /home/bwalker/src/netbeans/ide/editor/src/org/netbeans/modules/editor/NbEditorKit.java:628: warning: [unchecked] unchecked call to add(E) as a member of the raw type List [repeat] objects.add(null); [repeat] ^ [repeat] where E is a type-variable: [repeat] E extends Object declared in interface List

There are some remaining warnings. They are in generated code and therefore difficult to fix.

---

^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

[mbien]

hmm. sig tests are failing but you didn't really change anything in LSP code.

Class org.netbeans.modules.java.lsp.server.ui.UIContext

  "E1.2 - API type removed" : method protected java.util.concurrent.CompletableFuture org.netbeans.modules.java.lsp.server.ui.UIContext.showQuickPick(org.netbeans.modules.java.lsp.server.protocol.ShowQuickPickParams)

  "E1.2 - API type removed" : method protected java.util.concurrent.CompletableFuture org.netbeans.modules.java.lsp.server.ui.UIContext.showInputBox(org.netbeans.modules.java.lsp.server.protocol.ShowInputBoxParams)

[matthiasblaesing]

@BradWalker could you please rebase this onto current master and see if that fixes the issue, so that we can get this in? These things don't get better with time.

[BradWalker]

In process as we speak..

[mbien]

please make sure the commit has a useful message prior to merge.

[BradWalker]

Hey @mbien & @matthiasblaesing , could you take a quick look at this. I think I have everything up to do. But, it still fails a couple of the tests. It does not look like the test failures are related to me work though.

I need your eyes on it, if you don't mind.