netbeans icon indicating copy to clipboard operation
netbeans copied to clipboard

add-open flag for archetype

Open ebarboni opened this issue 3 years ago • 7 comments

Attempt to pass the add open flags to archetype linked to use for https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/pull/9

I should alter nbbuild/build.xml to populate branding so it can be used for replacement in the module

ebarboni avatar Mar 24 '22 20:03 ebarboni

it add flag like this '''-J--add-opens=java.base/java.net=ALL-UNNAMED -J--add-opens=java.base/java.lang.ref=ALL-UNNAMED''' maybe we should have the without -J version too.

ebarboni avatar Mar 25 '22 09:03 ebarboni

@mbien add the two properties for maven user will be easy to get both I guess even if user doesn't want them at the end. Easier to delete than to create.

ebarboni avatar Mar 25 '22 12:03 ebarboni

#3862 needs also the jvm version for flags

ebarboni avatar Mar 25 '22 16:03 ebarboni

wait PR to be merged and git checkout build.xml and default.xml. Idea of @matthiasblaesing was my first intention but did'nt proper understand where to put things.

ebarboni avatar Mar 25 '22 17:03 ebarboni

@ebarboni status of this one?

neilcsmith-net avatar Oct 11 '22 12:10 neilcsmith-net

later :D it needs also archetype side rewrite, I need to resync with @mbien

ebarboni avatar Oct 11 '22 13:10 ebarboni

maybe we should just add a comment to the maven template (which links to our JMS file) and call it a day, since this ended up more difficult than anticipated :)

(i really don't like the fact that this would need two properties, one with -J and one without)

mbien avatar Oct 11 '22 14:10 mbien