apache
Better implementation of PSR-4 Namespace rules
Consider src to be the base directory (PSR-4 definition) and the "surplus" leading segments as parts of the namespace prefix. Implementation is rough. For it to be better, i would need to add a configuration options in the project to let the user set the namespace prefix; fetch the configuration in this Checker and remove the appropriate leading part of the namespace. Unfortunately i don't know how to do that.
Can you submit it to the JIRA and attach an example project there? See also: https://netbeans.apache.org/participate/submit-pr.html
Did create the issue as improvements https://issues.apache.org/jira/browse/NETBEANS-6180
@aleferri I'm sorry I'm late... Maybe, I overlooked the notification.
src is hardcoded. So, I think we should get the source directory.
Unit tests are missing.
@junichi11 How do i get the environment inside the Hint? My original idea was to search for the top folder, but i couldn't figure how to get objects outside of the current file.
I would get the source directory like the following:
PhpModule phpModule = PhpModule.Factory.forFileObject(fileObject);
if (phpModule != null) {
FileObject sourceDirectory = phpModule.getSourceDirectory();
}
BTW, you should create a PR with not the master branch but the new branch.
@junichi11 Good catch.
@aleferri Please, create a branch in your clone, containing the number of the ticket and ideally also a few words, from the ticket title, typically (e.g. 1234-fix-npe).
Thanks.
Sorry to ask, but how i can run the tests? -Dcluster.config=php build netbeans, but the tests didn't run.
Either from the UI Kontextmenu of the project or on CLI: ant -f php/php.editor/build.xml test.
@aleferri which tests timeout? Your local run? Which test.
With flaky tests I regularly run the tests before my change, note which fail and run after. I consider my changes "sane" if the same set of tests succeeds and fails (and yes in perfect world this would not be necessary, but...)
@junichi11 @tmysik marked stale and removed from NB16 milestone for now. Please follow up as you see fit - re-add, re-review or close.
The implementation doesn't work, as it simply disable the warning even when the thing is wrong. I did that test by building the whole thing and opening my test project and also a should-fail one (aka i did a manual test). Unfortunately i am out of ideas on how to fix it and automated tests still don't run (not even one of them, all of them go in timeout).
I hadn't noticed how small the actual proposed changes were either - busy going through closing or marking stale PRs with milestones that hadn't been completed. Closing for discussion elsewhere then.