mynewt-nimble icon indicating copy to clipboard operation
mynewt-nimble copied to clipboard

nimble/host: add eatt opcode check in ble_eatt_l2cap_event_fn

Open piotrnarajowski opened this issue 1 year ago • 11 comments

Att opcode check caused l2cap disconnection when opcode included in received data was write command which is supported and can be used on eatt. Also, the comment seemed irrelevant. Fixes GATT/SR/GAW/BV-01-C

piotrnarajowski avatar Sep 20 '24 13:09 piotrnarajowski

#AutoPTS run mynewt GATT/SR/GAW/BV-01-C

piotrnarajowski avatar Sep 20 '24 13:09 piotrnarajowski

Scheduled PR https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363729615, board: nrf52, estimated start time: 15:24:29, test case count: 1, estimated duration: 0:01:07

Test cases to be runGATT/SR/GAW/BV-01-C

codecoup-tester avatar Sep 20 '24 13:09 codecoup-tester

#AutoPTS run mynewt GATT/SR --test_case_limit 10

piotrnarajowski avatar Sep 20 '24 13:09 piotrnarajowski

Scheduled PR https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363752694, board: nrf52, estimated start time: 15:37:02, test case count: 10, estimated duration: 0:06:42

Test cases to be runGATT/SR/GAC/BV-01-C
GATT/SR/GAC/BI-01-C
GATT/SR/GAD/BV-01-C
GATT/SR/GAD/BV-02-C
GATT/SR/GAD/BV-03-C
GATT/SR/GAD/BV-04-C
GATT/SR/GAD/BV-05-C
GATT/SR/GAD/BV-06-C
GATT/SR/GAR/BV-01-C
GATT/SR/GAR/BI-01-C

codecoup-tester avatar Sep 20 '24 13:09 codecoup-tester

AutoPTS Bot results: No failed test found.

Successful testsGATT GATT/SR/GAW/BV-01-C PASS

codecoup-tester avatar Sep 20 '24 13:09 codecoup-tester

AutoPTS Bot results: No failed test found.

Successful testsGATT GATT/SR/GAC/BI-01-C PASS
GATT GATT/SR/GAC/BV-01-C PASS
GATT GATT/SR/GAD/BV-01-C PASS
GATT GATT/SR/GAD/BV-02-C PASS
GATT GATT/SR/GAD/BV-03-C PASS
GATT GATT/SR/GAD/BV-04-C PASS
GATT GATT/SR/GAD/BV-05-C PASS
GATT GATT/SR/GAD/BV-06-C PASS
GATT GATT/SR/GAR/BI-01-C PASS
GATT GATT/SR/GAR/BV-01-C PASS

codecoup-tester avatar Sep 20 '24 13:09 codecoup-tester

FYI @KKopyscinski

piotrnarajowski avatar Sep 20 '24 13:09 piotrnarajowski

#AutoPTS run mynewt GATT/SR/GAW/BV-01-C

piotrnarajowski avatar Oct 01 '24 09:10 piotrnarajowski

Scheduled PR https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2385344896, board: nrf52, estimated start time: 12:00:35, test case count: 1, estimated duration: 0:01:09

Test cases to be runGATT/SR/GAW/BV-01-C

codecoup-tester avatar Oct 01 '24 09:10 codecoup-tester

AutoPTS Bot results: No failed test found.

Successful tests (1)GATT GATT/SR/GAW/BV-01-C PASS

codecoup-tester avatar Oct 01 '24 10:10 codecoup-tester

@rymanluk please review

piotrnarajowski avatar Oct 08 '24 11:10 piotrnarajowski