mynewt-nimble icon indicating copy to clipboard operation
mynewt-nimble copied to clipboard
verified publisher icon apache

nimble/host : Added new method of marking an api as deprecated.

Open IshaESP opened this issue 3 years ago • 5 comments

In the current code, using deprecated api's doesn't give any warnings. So, added a new way in which if these api's are used, compiler will give a warning associated with it.

IshaESP avatar Nov 02 '22 08:11 IshaESP

Hi @sjanc , Can you please take a look at this? The CI checks are failing as the files where these api's are used are giving warnings which are treated as errors.

IshaESP avatar Nov 02 '22 09:11 IshaESP

we build mynewt with -Werror so this will break build

maybe this should be a macro configurable via syscfg? eg MYNEWT_VAL(WARN_ON_DEPRECATED) or similar...

sjanc avatar Nov 07 '22 13:11 sjanc

we build mynewt with -Werror so this will break build

maybe this should be a macro configurable via syscfg? eg MYNEWT_VAL(WARN_ON_DEPRECATED) or similar...

Hi @sjanc , I added a configurable macro - BLE_SUPPRESS_DEPRECATE_WARN

IshaESP avatar Nov 08 '22 06:11 IshaESP

Hi @sjanc, Can you please take a look at this PR. Thanks.

IshaESP avatar Nov 14 '22 16:11 IshaESP

Style check summary

No suggestions at this time!

apache-mynewt-bot avatar Jan 13 '23 11:01 apache-mynewt-bot