mynewt-mcumgr icon indicating copy to clipboard operation
mynewt-mcumgr copied to clipboard

Documentation: Go 1.7 is no longer suitable for building CI

Open de-nordic opened this issue 6 years ago • 7 comments

Regarding "Command line tool" paragraph;

Due to changes applied with https://github.com/apache/mynewt-newt/commit/6a51e35565323ebe8feb8d1aa6e00960b6ce662e, which is usage of ProcessState.ExitCode(), in newt/util.go, the minimal requirement for go compiler is now version 1.11.1.

de-nordic avatar Oct 04 '19 07:10 de-nordic

I think it already required a minimum version of 1.12 because of this: https://github.com/apache/mynewt-newt/commit/53f9e0ca5a28efbcfe8aa2202a49ad64111b7d20

utzig avatar Oct 04 '19 10:10 utzig

@de-nordic Ah, you can probably disregard my comment, mynewt-mcumgr-cli depends only on newt/util so the version you mentioned seems correct.

utzig avatar Oct 04 '19 10:10 utzig

Might be, I have built go from the top of master at that point (27fc32ff01) for the purpose of building the tool, so I have been far beyond 1.11.1 anyway during build; I have tracked missing feature to be included within go 11.1.1, since the version mentioned.

de-nordic avatar Oct 04 '19 10:10 de-nordic

Seems at least 1.12 is needed becasue of os.ProcessState getting:

src/mynewt.apache.org/newt/util/util.go:498:10: state.ExitCode undefined (type *os.ProcessState has no field or method ExitCode)

With 1.11.6

baw-serafin avatar Nov 16 '20 10:11 baw-serafin

The README.md still mentions:

The command line tool requires Go 1.7 or later.

Is this the only place where this information is out-of-date?

chrta avatar Mar 22 '21 09:03 chrta

I want to work on this issue

alokprinc avatar Sep 09 '21 12:09 alokprinc

i have made changes merge if you are satisfied and tell me if any I can help you with.

alokprinc avatar Sep 23 '21 13:09 alokprinc