mynewt-core icon indicating copy to clipboard operation
mynewt-core copied to clipboard

Problems with mbuf docs?

Open cqexbesd opened this issue 5 years ago • 0 comments

I'm just reading the mbuf docs (https://mynewt.apache.org/latest/os/core_os/mbuf/mbuf.html). I am still learning so I don't want to say these are errors and not my confusion - but if that's the case then maybe the docs could be expanded to head off these questions :-)

  1. Regarding figure 1 (https://github.com/apache/mynewt-core/blob/master/docs/os/core_os/mbuf/pics/mbuf_fig1.png). The Data Buffer part of a Packet Header mbuf must be MBLEN - 24 - N bytes and not just MBLEN - 16?

  2. In the example code at the end (https://mynewt.apache.org/latest/os/core_os/mbuf/mbuf.html#using-mqueue is the closest link I can get) the call to os_mqueue_init has only two parameters when the docs further down say it should have three. I'm guessing the second parameter should be process_rx_data_queue. If not can the docs be expanded to explain how process_rx_data_queue does get called?

cqexbesd avatar May 16 '20 17:05 cqexbesd