mynewt-core
mynewt-core copied to clipboard
apache
add include of bsp_defs.h so that a BSP can override defines (for exa…
The bsp_defs.h in a specific BSP can redefine the idle stack size without changing the core of mynewt
Ok. Seems like bsp/bsp_defs.h is not a 'standard' file in mynewt BSPs. How about bsp/bsp.h?
Hi this was my original PR method, adding a syscfg (as for the main task stack size). However this was not approved... and the method of an include suggested.
brian
envoyé depuis ma nuage
On Fri, 27 Mar 2020, 18:53 Miguel Azevedo, [email protected] wrote:
@wes3 https://github.com/wes3 @andrzej-kaczmarek https://github.com/andrzej-kaczmarek @sjanc https://github.com/sjanc ^
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apache/mynewt-core/pull/2223#issuecomment-605159608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMIHRIH7O7L7GXUC45VZJ6TRJTR2XANCNFSM4LAKKU5Q .
Ok, I looked at https://github.com/apache/mynewt-core/pull/2138. Still hard to find out exactly why do you need redefine idle task's stack size.
The need is to have an ajustable size for the stack depending on the bsp, as during low power entry/exit (which takes place in the idle task) it is neccessary to run different code blocks to deinit/reinit the peripherals on a specific board.
This can involve calling up to the bsp and/or app (see my other PR for the method I propose to integrate this kind of system)
envoyé depuis ma nuage
On Fri, 27 Mar 2020, 20:30 Miguel Azevedo, [email protected] wrote:
Ok, I looked at #2138 https://github.com/apache/mynewt-core/pull/2138. Still hard to find out exactly why do you need redefine idle task's stack size.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apache/mynewt-core/pull/2223#issuecomment-605268844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMIHRIHEOZOVLZHC2SJKBK3RJT5E7ANCNFSM4LAKKU5Q .