mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

[BUGFIX] Fix AttributeError: module 'numpy' has no attribute 'bool'. (#21165), builds on PR #21223

Open mdengler opened this issue 1 year ago • 5 comments

Description

(Complete-er version of PR #21223)

bool replaces np.bool, a deprecated alias for the builtin bool; fixes #21165

Bug symptom: Importing mxnet with numpy 1.20+ results in

AttributeError: module 'numpy' has no attribute 'bool'.
np.bool was a deprecated alias for the builtin bool. To avoid this error in existing code, use bool by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.bool_ here. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Checklist

Essentials

  • [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [x] Changes are complete (i.e. I finished coding on this PR)
  • [x] All changes have test coverage
  • [x] Code is well-documented

Changes

  • [x] bool replaces np.bool everywhere, since np.bool was an alias to bool anyway, and is no longer defined/bound

Comments

  • Backwards compatible (according to numpy error message, quoted above)

mdengler avatar Oct 25 '23 21:10 mdengler

Hey @mdengler , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, clang, unix-gpu, edge, windows-cpu, unix-cpu, sanity, website, centos-gpu, centos-cpu, windows-gpu]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Oct 25 '23 21:10 mxnet-bot

您好,您发给我的邮件已收到,我会尽快查看。

mimiao2017 avatar Oct 25 '23 21:10 mimiao2017

@mxnet-bot run ci all

mdengler avatar Oct 28 '23 12:10 mdengler

什么时候能解决呢

wmjim avatar Nov 01 '23 07:11 wmjim

@mdengler : patch looks good to me, thanks. This project was retired by the community, so there will be no new release anymore. FYI: I'm using your patch to use the mxnet ImageRecordIter code in a PyTorch project for image classification, which is in my setup almost twice as fast as WebDataSet.

lgov avatar Nov 05 '23 13:11 lgov