mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

[BUGFIX] utils.py - bool = bool

Open mwunderl opened this issue 10 months ago • 1 comments

Description

Importing mxnet with numpy 1.20+ results in

AttributeError: module 'numpy' has no attribute 'bool'. np.bool was a deprecated alias for the builtin bool. To avoid this error in existing code, use bool by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.bool_ here. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

np.bool was a deprecated alias for the builtin bool, so replace np.bool with bool

Tested locally with mxnet-1.9.1-py3-none-manylinux2014_x86_64.whl , numpy 1.24.4, python 3.10.12

Checklist

Essentials

  • [ x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [x ] Changes are complete (i.e. I finished coding on this PR)
  • [x ] All changes have test coverage
  • [ x] Code is well-documented

cf https://github.com/apache/mxnet/issues/21165

mwunderl avatar Oct 11 '23 20:10 mwunderl

Hey @mwunderl , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, miscellaneous, centos-gpu, windows-gpu, windows-cpu, edge, clang, sanity, unix-gpu, centos-cpu, unix-cpu]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Oct 11 '23 20:10 mxnet-bot