mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

[FEATURE][OP] Support FInplaceIdentity property for legacy operators

Open shuo-ouyang opened this issue 4 years ago • 1 comments

Description

We notice that only nnvm operators support FInplaceIdentity property but legacy operators do not, which leads to InplaceOption failing when the storage reference count is large than 1. We add FInplaceIdentity support for legacy operators in this PR.

Checklist

Essentials

  • [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [x] Changes are complete (i.e. I finished coding on this PR)
  • [ ] All changes have test coverage
  • [x] Code is well-documented

Changes

  • [ ] Feature1, tests, (and when applicable, API doc)
  • [ ] Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

shuo-ouyang avatar Oct 28 '21 07:10 shuo-ouyang

Hey @shuo-ouyang , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, centos-gpu, website, edge, unix-cpu, miscellaneous, windows-cpu, clang, unix-gpu, sanity, windows-gpu]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Oct 28 '21 07:10 mxnet-bot