mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

Enable float32 data type in linalg cholesky test

Open mozga-intel opened this issue 3 years ago • 4 comments

Description

Regarding #20505 . The Cholesky test on the current master uses only float64 data type. Checking Float32 data type is disabled. Is this intended or negligence? Here is a quick fix to check on float32 data type.

Checklist

Essentials

  • [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [ ] Changes are complete (i.e. I finished coding on this PR)
  • [ ] All changes have test coverage
  • [ ] Code is well-documented

Changes

  • [ ] Feature1, tests, (and when applicable, API doc)
  • [ ] Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

mozga-intel avatar Aug 10 '21 11:08 mozga-intel

Hey @mozga-intel , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, sanity, unix-cpu, centos-cpu, miscellaneous, windows-gpu, edge, centos-gpu, windows-cpu, unix-gpu]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Aug 10 '21 11:08 mxnet-bot

@mxnet-bot run ci [all]

mozga-intel avatar Aug 25 '21 09:08 mozga-intel

Jenkins CI successfully triggered : [clang, unix-gpu, unix-cpu, centos-gpu, website, windows-cpu, edge, centos-cpu, windows-gpu, sanity, miscellaneous]

mxnet-bot avatar Aug 25 '21 09:08 mxnet-bot

Looks like the atol and rtol need to be adjusted for lower precision cholesky op.

szha avatar Aug 25 '21 13:08 szha