mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

[mxnet 2.0] deprecate gluon.model_zoo, image.detection

Open zhreshold opened this issue 4 years ago • 2 comments

Description

Deprecate gluon model zoo, image.detection in favor of gluon toolkits and gluon transform functions, respectively.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [ ] Changes are complete (i.e. I finished coding on this PR)
  • [ ] All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [ ] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • [ ] Feature1, tests, (and when applicable, API doc)
  • [ ] Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

zhreshold avatar Jun 03 '20 19:06 zhreshold

Hey @zhreshold , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, clang, windows-gpu, windows-cpu, miscellaneous, website, unix-cpu, centos-cpu, unix-gpu, centos-gpu, edge]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Jun 03 '20 19:06 mxnet-bot

I guess it's fine. The existing models in the model zoo are not trained with the numpy API anyway

eric-haibin-lin avatar Jun 11 '20 15:06 eric-haibin-lin