mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

Published 20 hours ago • verified publisher icon apache

upload snail for gluon

Open seujung opened this issue 5 years ago • 15 comments

Description

upload example for snail code SNAIL(A Simple Neural Attentive Meta-Learniner) is a kind of meta-learning algorithm. Train network using omniglot dataset

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [ ] Changes are complete (i.e. I finished coding on this PR)
  • [ ] All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [ ] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • [ ] Feature1, tests, (and when applicable, API doc)
  • [ ] Feature2, tests, (and when applicable, API doc)

Comments

  • reset previous pr #13966

seujung avatar Mar 08 '19 07:03 seujung

@mxnet-label-bot add [Gluon, Example, pr-awaiting-review]

vandanavk avatar Mar 08 '19 15:03 vandanavk

@szha @eric-haibin-lin This PR is ready for your review, please take a look, thanks!

pinaraws avatar Mar 20 '19 00:03 pinaraws

@szha @eric-haibin-lin Could you please help review? thanks

abhinavs95 avatar Mar 29 '19 22:03 abhinavs95

@szha Ping for review :)

piyushghai avatar Apr 09 '19 00:04 piyushghai

@ThomasDelteil Can you help review this PR?

Roshrini avatar Apr 17 '19 15:04 Roshrini

@cgraywang you may be interested

eric-haibin-lin avatar Apr 24 '19 06:04 eric-haibin-lin

@ThomasDelteil @thomelane can you please review this example. Thanks

anirudhacharya avatar May 02 '19 20:05 anirudhacharya

@seujung Thanks for your contribution! @ThomasDelteil , @szha @cgraywang Could you please review this PR? Thanks!

karan6181 avatar May 21 '19 21:05 karan6181

@ThomasDelteil @cgraywang could you help review? thanks

abhinavs95 avatar May 31 '19 22:05 abhinavs95

Is there anyone to review my code? I think my PR is still pending.

seujung avatar Jun 07 '19 05:06 seujung

Please execute pylint on these files using ci/other/pylintrc in incubator-mxnet folder. Something like this pylint --rcfile=ci/other/pylintrc --ignore-patterns="..so$$,..dll$$,..dylib$$" example/gluon/snail/*.py

vandanavk avatar Jun 16 '19 19:06 vandanavk

@seujung Could you please address @vandanavk comments?

karan6181 avatar Jul 18 '19 23:07 karan6181

@vandanavk @karan6181 I execute the code and the result is as folliw.

pylint --rcfile=ci/other/pylintrc --ignore-patterns="..so$$,..dll$$,..dylib$$" example/gluon/snail/*.py
Using config file /Users/digit82/git_repo/incubator-mxnet/ci/other/pylintrc

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

seujung avatar Jul 20 '19 11:07 seujung

@ThomasDelteil Can you review this PR ?

piyushghai avatar Aug 02 '19 19:08 piyushghai

@ThomasDelteil @cgraywang Could you please review this PR? Thanks!

karan6181 avatar Aug 29 '19 16:08 karan6181