[SSHD-1283] Added configuration property to control whether ScpShell is enabled

[lgoldstein]

[lgoldstein]

@tomaswolf Could you take a look ? Thx

[tomaswolf]

BTW: I think we should have a new release 2.9.1 with only the fixes for Java 8 (SSHD-1281/SSHD-1285), with anything else in a later release. In particular new features should not be in 2.9.x but in 2.10.0.

[lgoldstein]

BTW: I think we should have a new release 2.9.1 with only the fixes for Java 8 (SSHD-1281/SSHD-1285), with anything else in a later release. In particular new features should not be in 2.9.x but in 2.10.0.

Agreed

[lgoldstein]

Perhaps I'm missing something (can only review this in the Github Web UI right now), but I don't see any use of this list.

No, you are not missing anything - I am still thinking about how to use it - if I cannot make up my mind I will delete it...

[lgoldstein]

This doesn't appear to be a non-standard option. Normal OpenSSH allows overriding any config setting via "-o" on the command-line, and PreferredAuthentications is a standard SSH config key.

You are right - will re-phrase or move it to the correct section.

[lgoldstein]

I don't see any connection between commit https://github.com/apache/mina-sshd/commit/4e2f817c1eff380d083cf43df5d1aec6d8830564 and SSHD-1281. Please fix that typo in the commit message.

Will do