maven icon indicating copy to clipboard operation
maven copied to clipboard

MNG-5909 : Add combined expression evaluator to file activation property

Open lbndev opened this issue 9 years ago • 10 comments

Suggested solution for MNG-5909 : the file activation element will understand basic boolean expressions such as and(file1,file2) or(file3,!file4) etc... Please see added unit test for expression examples. If you think this could benefit to other activators (property, os, ...) please say so and I will happily modify them too. I will also post a message on maven dev mailing list.

lbndev avatar Aug 17 '16 21:08 lbndev

@lbndev Can you redo the PR only containing the actual change (IIUC this is only commit https://github.com/apache/maven/pull/92/commits/2efe3d2d3b92685d83c2598a7f85c39ebdd59ebc). Otherwise it is impossible to review.

kwin avatar Jun 29 '18 09:06 kwin

Hello @kwin,

Wow, resurrecting an old request ! I rebased my change on branch "pre-reset-master" (see branch MNG-5909-oldmaster), then I cherry-picked in on top of the new master, fixing conflicts.

It used to work on the initial version of this PR (almost 2 years ago), but I should take time to build & test this new version just to make sure it plays nicely with all the other changes in maven over the last 2 years. Maybe I'll find time during the weekend.

Thanks for your interrest in this PR

Loïc

lbndev avatar Jul 27 '18 22:07 lbndev

UP

bdelion avatar Jul 10 '19 21:07 bdelion

This does not incur a model change, does it?

michael-o avatar Jul 10 '19 22:07 michael-o

Any chance this will ever be accepted?

marcelstoer avatar Apr 01 '21 06:04 marcelstoer

I will try to look at this in the next two weeks.

michael-o avatar Apr 01 '21 07:04 michael-o

@marcelstoer Please ping me by mid of April.

michael-o avatar Apr 05 '21 11:04 michael-o

Please ping me by mid of April.

Ping

marcelstoer avatar Apr 05 '21 12:04 marcelstoer

Please ping me by mid of April.

Ping

Seriously? Do you live a by different calendar? You consider 2021-04-05 mid of April?

michael-o avatar Apr 05 '21 12:04 michael-o

Not sure what the intention of this comment was (i.e. why I should ping you) but "by mid April" means no later than mid April. You meant "around" mid April instead?

marcelstoer avatar Apr 05 '21 12:04 marcelstoer