[MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin

[nielsbasjes]

This is a proposed merge request that came from the discussion of https://github.com/apache/maven-shade-plugin/pull/26 https://issues.apache.org/jira/browse/MSHADE-326

Essentially the discussion (with @michael-o @rfscholte) came to the point where it seemed that the rootcause of the problem in the maven-shade-plugin was really a problem in maven itself where it does not reload the changes in the project (after shade modified it) thus causing incorrect data to be read in the rest of a multi-module project.

This simply removes this "skip cache refresh" code (that was originally annotated as a hack!)

Following this checklist to help us incorporate your contribution quickly and easily:

• [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).
• [x] Each commit in the pull request should have a meaningful subject line and body.
• [ ] Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles, where you replace MNG-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• [ ] You have run the Core IT successfully.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

• [x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• [x] In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

We will also need to reconsider MNG-6638 becaue we cannot drop this cache with fixing MNG-6638. We obviously need to check whether this is stale..

[nielsbasjes]

@michael-o How can MNG-6638 be tested? Looking at the changes for this I only see some additional code in MavenMetadataSource.java that retrieves some existing data, no tests (and the removal of the hack comment).

[nielsbasjes]

The only test that failed in CI is MavenITmng5895CIFriendlyUsageWithPropertyTest and it only fails on Windows with Java 8. Looking at the original issue https://issues.apache.org/jira/browse/MNG-5895 (fixed about 4 years ago) there is a comment from December 2020 that seems to indicate problems on Windows.