maven
maven copied to clipboard
[MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
as discussed in the dev mailing list [1][2] this PR removes depreciation on org.apache.maven.plugin.logging.Log
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like
[MNG-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMNG-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run
mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the Core IT
Two unrelatd ITs tests are failing locally
[ERROR] Errors:
[ERROR] MavenITmng5669ReadPomsOnce>AbstractMavenIntegrationTestCase.runTest:255->testWithBuildConsumer:119 » Verification
[ERROR] MavenITmng5669ReadPomsOnce>AbstractMavenIntegrationTestCase.runTest:255->testWithoutBuildConsumer:65 » Verification
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
Hi @McFoggy , isnt only Log which shouldn't be deprecated and the implementation can stay deprecated if we want to forward them to slf4j internally - I suspect we will want to do it in DefaultLog but for now it uses plexus which is not desired anymore from what I understood?
Hi Romain,
isn't only Log which shouldn't be deprecated
I hesitated on this. I can switch it back for the 2 implementations if it is more aligned with the long term goal.
@McFoggy not a big blocker for me since removing the deprecation on Log is the "big thing" there IMHO but think it is worth to have an implementation not deprecated (maybe default only?).
One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu
One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu
Sorry @slachiewicz I do not get your point.
Sorry, that should be comment to other PR
@rmannibucau finally I only removed depreciation on org.apache.maven.plugin.logging.Log, there was a consensus for this point let's stick to it.
I consider it barely realistic to remove SLF4J API in Core and replace it with something else. All components will fail anyway, Wagon, SCM, Shared, etc. This is just too short sighted.
Proposal to supersede this https://github.com/apache/maven/pull/565