maven icon indicating copy to clipboard operation
maven copied to clipboard

Update artifact-handlers.apt

Open kwin opened this issue 1 year ago • 9 comments

Clarify that the extension used outside repositories for pom files usually differs

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • [ ] Also format the first line of the commit message like [MNG-XXX] SUMMARY. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

kwin avatar Apr 05 '24 08:04 kwin

Am unsure is it meaningful at all to speak about artifacts "outside of repository"...

cstamas avatar Apr 08 '24 11:04 cstamas

Well for me extension is mostly connected to files used outside a repo, and this is the only type where in repo and outside repo extension differs.

kwin avatar Apr 08 '24 12:04 kwin

what people need to understand is that artifact handler is for a dependency, not for a file anywhere and dependencies are in repository (most of the time, I know)

outside of repo, any file can have any extension: call the file as you wish

hboutemy avatar Apr 14 '24 17:04 hboutemy

How are people supposed to know the extension of a dependency? Although admittedly rarely necessary, this is important if you use resolver API directly.

kwin avatar Apr 14 '24 18:04 kwin

The dependency extension is told by type. Dependency is never "anywhere on disk", it may come from repo only.

You mix few things here...

cstamas avatar Apr 14 '24 18:04 cstamas

When you deploy/install artifacts to a repo they come from a file with an extension. Usually this extension is the same as being used inside the repo except for POM!

kwin avatar Apr 14 '24 18:04 kwin

The depensency extension is told by type. Deoendency is never "anywhere on disk", it may come from repo only.

You mix few things here...

cstamas avatar Apr 14 '24 18:04 cstamas

Wrong, for example signatures are also tmp files, getting their "final form" only at deploy

cstamas avatar Apr 14 '24 18:04 cstamas

Recognizing (or assuming) anything about not yet installed/deployed artifact is wrong, as producer may also use anything, like tmp file. It is artifact that you need to inspect, not the backing file.

cstamas avatar Apr 14 '24 18:04 cstamas

No consensus here, therefore closing.

kwin avatar May 18 '24 15:05 kwin